Thread

Re: [Patch]Add Graph* node support to expression_tree_mutator

Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> — 2026-05-11T06:15:59Z

On Mon, May 4, 2026 at 9:09 PM Peter Eisentraut <peter@eisentraut.org> wrote:
>
> On 30.04.26 08:44, Ashutosh Bapat wrote:
> > On Thu, Apr 30, 2026 at 2:17 AM Robert Haas <robertmhaas@gmail.com> wrote:
> >>
> >
> > Thanks for reviewing the patch.
> >
> >> Thanks for working on this. I ran into it independently today, and
> >> then discovered this thread. In expression_tree_mutator_impl,
> >> T_GraphLabelRef can be added to the "Primitive node types with no
> >> expression subnodes" section just as was done in
> >> expression_tree_walker_impl.
> >
> > Right. Fixed in the attached patch. Both GraphPropertyLabel and
> > GraphLabelRef need to be placed in that section since both are
> > primitive nodes.
>
> Committed.  (I reformatted the test query a little bit as you had
> suggested upstream.  Also, the ordering of the switch cases was slightly
> different between the walker and the mutator, which I fixed.)
>

Thanks. The changes look good to me.

-- 
Best Wishes,
Ashutosh Bapat