Re: Test to dump and restore objects left behind by regression

Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>

From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>

To: Alvaro Herrera <alvherre@alvh.no-ip.org>

Cc: Daniel Gustafsson <daniel@yesql.se>, Tom Lane <tgl@sss.pgh.pa.us>, Michael Paquier <michael@paquier.xyz>, vignesh C <vignesh21@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-04-01T07:43:07Z

Lists: pgsql-hackers

Attachments

0002-Use-only-one-format-and-make-the-test-run-d-20250401.patch (text/x-patch) patch 0002
0001-Test-pg_dump-restore-of-regression-objects-20250401.patch (text/x-patch) patch 0001
0003-Do-not-dump-statistics-in-the-file-dumped-f-20250401.patch (text/x-patch) patch 0003

On Tue, Apr 1, 2025 at 11:52 AM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
>
> On 2025-Mar-31, Daniel Gustafsson wrote:
>
> > Given where we are in the cycle, it seems to make sense to stick to using the
> > schedule we already have rather than invent a new process for generating it,
> > and work on that for 19?
>
> No objections to that.  I'll see about getting this committed during my
> morning today, so that I have plenty of time to watch the buildfarm.

Thanks Alvaro.
Just today morning, I found something which looks like another bug in
statistics dump/restore [1]. As Daniel has expressed upthread [2], we
should go ahead and commit the test even if the bug is not fixed. But
in case it creates a lot of noise and makes the build farm red, we
could suppress the failure by not dumping statistics for comparison
till the bug is fixed. PFA patchset which reintroduces 0003 which
suppresses the statistics dump - in case we think it's needed. I have
made some minor cosmetic changes to 0001 and 0002 as well.

I will also watch buildfarm too, once you commit the patch.

[1] https://www.postgresql.org/message-id/CAExHW5sFOgcUkVtZ8=QCAE+jv=sbNdBKq0xZCNJTh7019ZM+CQ@mail.gmail.com

--
Best Wishes,
Ashutosh Bapat

Commits

Hide expensive pg_upgrade test behind PG_TEST_EXTRA
- d185161e4739 18.0 landed
- 37fc1803cc12 19 (unreleased) landed
Set log_statement=none in t/002_pg_upgrade.pl
- 64fba9c61787 18.0 landed
002_pg_upgrade.pl: Move pg_dump test code for better stability
- 8806e4e8deb1 18.0 landed
002_pg_upgrade.pl: rename some variables for clarity
- abe56227b2e2 18.0 landed
Verify roundtrip dump/restore of regression database
- 172259afb563 18.0 landed
Refactor TAP test code for file comparisons into new routine in Utils.pm
- 169208092f5c 18.0 landed
Virtual generated columns
- 83ea6c54025b 18.0 cited
Put generated_stored test objects in a schema
- 894be11adfa6 18.0 cited
Introduce "builtin" collation provider.
- 2d819a08a1cb 17.0 cited
Revert "Improve compression and storage support with inheritance"
- 74563f6b9021 17.0 cited