Horton

Re: Report bytes and transactions actually sent downtream

Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>

View thread
From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
To: shveta malik <shveta.malik@gmail.com>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, Ashutosh Sharma <ashu.coek88@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-11-03T14:23:30Z
Lists: pgsql-hackers

Attachments

On Mon, Nov 3, 2025 at 3:25 PM shveta malik <shveta.malik@gmail.com> wrote:
>
> > So I propose to just add comment
> >
> > in pgoutput_truncate()
> > /*
> > * Even if we filtered out some relations, we still send a TRUNCATE
> > * message for the remaining relations. Since the change, as a whole, is
> > * not filtered out we don't increment filteredBytes.
> > */
> >
> > and in pgoutput_change
> > /*
> > * Send the data. Even if we end up filtering some columns while sending the
> > * message, we won't consider the change, as a whole, to be filtered out. Hence
> > * won't increment the filteredBytes.
> > */
> >
> > Does that look good?
>
> Yes. Works for me.

Here's a patch with all comments addressed.

-- 
Best Wishes,
Ashutosh Bapat