Horton

Re: [PATCH] pgindent truncates last line of files missing a trailing newline

Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>

View thread View on postgr.es
From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>, Akshay Joshi <akshay.joshi@enterprisedb.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2026-02-17T02:20:42Z
Lists: pgsql-hackers 
On Mon, Feb 16, 2026 at 10:20 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Andrew Dunstan <andrew@dunslane.net> writes:
> > Yeah. I wonder if we shouldn't be just ensuring that there is a line
> > feed at the end of the buffer, i.e. add one if it's not there. We
> > shouldn't be adding files without a trailing LF, and ensuring there is
> > one seems like a reasonable thing to do in pg_bsd_indent.
>
> +1

+1. That will allow me to remove some code from my patch preparation
script. Ref. [1]

[1] https://www.postgresql.org/message-id/flat/CAExHW5v8u7-2H2LqWP3ybhh5GnAVVeCOYuTfkg9pmdnrLwAtNA%40mail.gmail.com#fdbb87e825f89e7109dfb0ed959b2dd4

-- 
Best Wishes,
Ashutosh Bapat

Commits

  1. pgindent: ensure all C files end with a newline.