Re: SQL Property Graph Queries (SQL/PGQ)

Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>

From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>

To: Peter Eisentraut <peter@eisentraut.org>

Cc: pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2024-07-22T12:01:42Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix some typos and make small stylistic improvements
- 5282bf535e47 19 (unreleased) landed
Cleanup users and roles in graph_table_rls test
- 040a56be4bcc 19 (unreleased) landed
Dump labels in reproducible order
- c9babbc8816a 19 (unreleased) landed
SQL Property Graph Queries (SQL/PGQ)
- 2f094e7ac691 19 (unreleased) landed
Factor out constructSetOpTargetlist() from transformSetOperationTree()
- 8c2b30487cc7 19 (unreleased) landed
Sort out table_open vs. relation_open in rewriter
- d537f59fbbfc 19 (unreleased) landed
Rename grammar nonterminal to simplify reuse
- 8080f44f96a9 19 (unreleased) landed
Make ecpg parse.pl more robust with braces
- 7f88553ceaca 19 (unreleased) landed
Don't lock partitions pruned by initial pruning
- 525392d5727f 18.0 cited
Remove pg_regex_collation
- 792b2c7e6d92 18.0 cited
Use auxv to check for CRC32 instructions on ARM.
- aac831cafa6f 18.0 cited
Fix inappropriate uses of atol()
- f5a1311fccd2 18.0 cited
Remove unnecessary array object_classes[] in dependency.c
- ef5e2e90859a 17.0 cited

Attachments

0002-pgperltidy-fixes-20240722.patch (text/x-patch) patch 0002
0004-Fix-spurious-column-not-found-error-20240722.patch (text/x-patch) patch 0004
0003-Fix-compilation-error-20240722.patch (text/x-patch) patch 0003
0005-support-WHERE-clause-in-graph-pattern-20240722.patch (text/x-patch) patch 0005
0001-WIP-SQL-Property-Graph-Queries-SQL-PGQ-20240722.patch (text/x-patch) patch 0001

On Wed, Jul 17, 2024 at 11:04 AM Ashutosh Bapat
<ashutosh.bapat.oss@gmail.com> wrote:
>
> On Mon, Jul 8, 2024 at 7:07 PM Ashutosh Bapat
> <ashutosh.bapat.oss@gmail.com> wrote:
> >
> >
> >
> > On Thu, Jun 27, 2024 at 6:01 PM Peter Eisentraut <peter@eisentraut.org> wrote:
> >>
> >> Here is a new version of this patch.  I have been working together with
> >> Ashutosh on this.  While the version 0 was more of a fragile demo, this
> >> version 1 has a fairly complete minimal feature set and should be useful
> >> for playing around with.  We do have a long list of various internal
> >> bits that still need to be fixed or revised or looked at again, so there
> >> is by no means a claim that everything is completed.
> >
> >
> > PFA the patchset fixing compilation error reported by CI bot.
> > 0001 - same as previous one
> > 0002 - fixes compilation error
> > 0003 - adds support for WHERE clause in graph pattern missing in the first patch.
> >
>
> There's a test failure reported by CI. Property graph related tests
> are failing when regression is run from perl tests. The failure is
> reported only on Free BSD.

I thought it's related to FreeBSD but the bug could be observed
anywhere with -DRELCACHE_FORCE_RELEASE. It's also reported indirectly
by valgrind.

When infering properties of an element from the underlying table's
attributes, the attribute name pointed to the memory in the heap tuple
of pg_attribute row. Thus when the tuple was released, it pointed to a
garbage instead of actual column name resulting in column not found
error.

Attached set of patches with an additional patch to fix the bug.

0001 - same as previous one
0002 - fixes pgperltidy complaints
0003 - fixes compilation failure
0004 - fixes issue seen on CI
0005 - adds support for WHERE clause in graph pattern missing in the
first patch.

Once reviewed, patches 0002 to 0005 should be merged into 0001.

-- 
Best Wishes,
Ashutosh Bapat