Re: [PATCH] clarify palloc comment on quote_literal_cstr
Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Steve Chavez <steve@supabase.io>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2025-04-08T08:26:46Z
Lists: pgsql-hackers
On Tue, Apr 8, 2025 at 10:49 AM Michael Paquier <michael@paquier.xyz> wrote: > > On Tue, Apr 08, 2025 at 08:47:53AM +0530, Ashutosh Bapat wrote: > > Thanks for addressing the comment. > > > > In PG code, we start a multiline comment with just /* on the first > > line and end with just */ on the last line. All the lines in-between > > start with * . Please check other comments in the file. > > > > I would write a., b. c. d. on separate lines. > > Hmm. I don't think that grouping all these details in the same > comment block is an improvement in this case compared to the first > version, where it is clear which part of the calculation applies to > what. In short, I'm OK with how things are on HEAD. Ah! I didn't realize it was committed already. -- Best Wishes, Ashutosh Bapat
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Clarify comment for worst-case allocation in quote_literal_cstr()
- c36eda259130 18.0 landed