Re: Test to dump and restore objects left behind by regression

Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>

From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>

To: Michael Paquier <michael@paquier.xyz>

Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Daniel Gustafsson <daniel@yesql.se>, Tom Lane <tgl@sss.pgh.pa.us>, Peter Eisentraut <peter@eisentraut.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-02-25T06:29:24Z

Lists: pgsql-hackers

Attachments

0001-Test-pg_dump-restore-of-regression-objects-20250225.patch (text/x-patch) patch 0001
0003-Do-not-dump-statistics-in-the-file-dumped-f-20250225.patch (text/x-patch) patch 0003
0002-Filter-COPY-statements-with-differing-colum-20250225.patch (text/x-patch) patch 0002

On Tue, Feb 11, 2025 at 5:53 PM Ashutosh Bapat
<ashutosh.bapat.oss@gmail.com> wrote:
>
> Hi Michael,
>
>
> On Sun, Feb 9, 2025 at 1:25 PM Michael Paquier <michael@paquier.xyz> wrote:
> >
> > On Fri, Feb 07, 2025 at 07:11:25AM +0900, Michael Paquier wrote:
> > > Okay, thanks for the feedback.  We have been relying on diff -u for
> > > the parts of the tests touched by 0001 for some time now, so if there
> > > are no objections I would like to apply 0001 in a couple of days.
> >
> > This part has been applied as 169208092f5c.
>
> Thanks. PFA rebased patches.

PFA rebased patches.

After rebasing I found another bug and reported it at [1].

For the time being I have added --no-statistics to the pg_dump command
when taking a dump for comparison.

[1] https://www.postgresql.org/message-id/CAExHW5vf9D+8-a5_BEX3y=2y_xY9hiCxV1=C+FnxDvfprWvkng@mail.gmail.com

-- 
Best Wishes,
Ashutosh Bapat

Commits

Hide expensive pg_upgrade test behind PG_TEST_EXTRA
- d185161e4739 18.0 landed
- 37fc1803cc12 19 (unreleased) landed
Set log_statement=none in t/002_pg_upgrade.pl
- 64fba9c61787 18.0 landed
002_pg_upgrade.pl: Move pg_dump test code for better stability
- 8806e4e8deb1 18.0 landed
002_pg_upgrade.pl: rename some variables for clarity
- abe56227b2e2 18.0 landed
Verify roundtrip dump/restore of regression database
- 172259afb563 18.0 landed
Refactor TAP test code for file comparisons into new routine in Utils.pm
- 169208092f5c 18.0 landed
Virtual generated columns
- 83ea6c54025b 18.0 cited
Put generated_stored test objects in a schema
- 894be11adfa6 18.0 cited
Introduce "builtin" collation provider.
- 2d819a08a1cb 17.0 cited
Revert "Improve compression and storage support with inheritance"
- 74563f6b9021 17.0 cited