Horton

Re: anonymous unions (C11)

Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>

View thread View on postgr.es
From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
To: Álvaro Herrera <alvherre@kurilemu.de>
Cc: Chao Li <li.evan.chao@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-09-30T14:41:08Z
Lists: pgsql-hackers 
On Tue, Sep 30, 2025 at 5:14 PM Álvaro Herrera <alvherre@kurilemu.de> wrote:
>
> On 2025-Sep-30, Ashutosh Bapat wrote:
>
> > Attached patch fixes those errors for me.
>
> > diff --git a/src/common/cryptohash.c b/src/common/cryptohash.c
> > index fc0555d2f99..e8a35c2ec35 100644
> > --- a/src/common/cryptohash.c
> > +++ b/src/common/cryptohash.c
> > @@ -61,7 +61,7 @@ struct pg_cryptohash_ctx
> >               pg_sha256_ctx sha256;
> >               pg_sha384_ctx sha384;
> >               pg_sha512_ctx sha512;
> > -     }                       data;
> > +     };
> >  };
>
> Isn't this patch 0015 in Peter's series?

I found the compilation errors after pulling the latest sources at
that time. I thought the patch series is committed and hence this
report and patch. Didn't look at the patch series.

But the problematic commit has been reverted since then.

-- 
Best Wishes,
Ashutosh Bapat

Commits

  1. Make some use of anonymous unions [reloptions]

  2. Make some use of anonymous unions [libpq-oauth]

  3. Make some use of anonymous unions [DSM registry].

  4. Make some use of anonymous unions [pg_locale_t]

  5. Make some use of anonymous unions [pgcrypto]

  6. Make some use of anonymous unions [plpython]

  7. Make some use of anonymous unions [reorderbuffer xact_time]