Re: Add "format" target to make and ninja to run pgindent and pgperltidy
Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
Daniel Gustafsson <daniel@yesql.se>
Date: 2025-12-31T13:54:12Z
Lists: pgsql-hackers
On Wed, Dec 31, 2025 at 5:06 PM Jelte Fennema-Nio <postgres@jeltef.nl> wrote: > > This tries to make running formatting a lot easier for committers, but > primarily for new contributors. You can not format the files by simply > running one of the folowing: > > make format > ninja -C build format > I generally like the idea. Since perltidy is not enforced regularly (like pgindent), running it usually ends up modifying files which are not part of the patch. So I avoid it if not necessary. Do you propose to make it optional? -- Best Wishes, Ashutosh Bapat