Horton

Re: Support NOT VALID / VALIDATE constraint options for named NOT NULL constraints

Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>

View thread View on postgr.es
From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Rushabh Lathia <rushabh.lathia@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2025-02-25T04:33:07Z
Lists: pgsql-hackers 
On Fri, Feb 21, 2025 at 6:25 PM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
>
> On 2025-Feb-21, Ashutosh Bapat wrote:
>
> > If I apply your patches, build binaries, I see failure. I reverted
> > your patches, built binaries, I don't see failure. I apply your
> > patches again, built binaries, it fails again.
>
> I can't reproduce the problem either.  Are you running asserts disabled
> or enabled?  Can you please share what upgrade problems are reported?

I have shared the relevant output from regress_*_ log in an earlier
email. Do you need something else?

> Do you have additional tests in pg_upgrade that aren't in the tree?

No. I did intend to run my dump/restore test but the test even without
those patches applied.

-- 
Best Wishes,
Ashutosh Bapat

Commits

  1. Allow NOT NULL constraints to be added as NOT VALID

  2. Add missing deparsing of [NO] IDENT to XMLSERIALIZE()

  3. backend launchers void * arguments for binary data

  4. Add pg_constraint rows for not-null constraints

  5. Create the infrastructure for planner support functions.

  6. Add prokind column, replacing proisagg and proiswindow