Horton

Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided.

Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>

View thread View on postgr.es
From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Cc: Shubham Khanna <khannashubham1197@gmail.com>, Nisha Moond <nisha.moond412@gmail.com>, Ajin Cherian <itsajin@gmail.com>, Peter Smith <smithpb2250@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, vignesh C <vignesh21@gmail.com>, Shlok Kyal <shlok.kyal.oss@gmail.com>
Date: 2025-03-25T11:25:27Z
Lists: pgsql-hackers 
On Tue, Mar 25, 2025 at 3:22 PM Hayato Kuroda (Fujitsu)
<kuroda.hayato@fujitsu.com> wrote:
>
> Dear Shubham,
>
> > The attached patches contain the suggested changes.
>
> Thanks for updating the patch. I reviewed only 0001 because they would be committed separately.
> Few comments:
>
> 01.
> ```
> +       For every non-template database on the source server, create one
> +       subscription on the target server in the database with the same name.
> ```
>
> It is quite confusing for me; We do not have to describe users that this command
> checks databases of the source server. How about something like:
> "Create one subscription per all non-template databases on the target server."
>

The new description doesn't mention the link between the source and
target database. And I think it's incorrect. Not all databases on the
target server will receive a subscription. Only those which have the
same name as a database on the source server. Am I correct? I prefer
the previous wording, even if it's a bit complex, over a simpler but
incorrect description.

-- 
Best Wishes,
Ashutosh Bapat

Commits

  1. Cosmetic fixes for pg_createsubscriber's -all option.

  2. pg_createsubscriber: Add '--all' option.