Re: define PG_REPLSLOT_DIR

Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>

From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, pgsql-hackers@lists.postgresql.org
Date: 2024-08-21T04:44:20Z
Lists: pgsql-hackers
If this isn't in commitfest already, please add it there.

On Tue, Aug 20, 2024 at 9:58 PM Bertrand Drouvot
<bertranddrouvot.pg@gmail.com> wrote:
>
> Hi,
>
> On Tue, Aug 20, 2024 at 12:06:52PM +0000, Bertrand Drouvot wrote:
> > Hi,
> >
> > On Tue, Aug 20, 2024 at 05:41:48PM +0900, Michael Paquier wrote:
> > > On Tue, Aug 20, 2024 at 11:10:46AM +0530, Ashutosh Bapat wrote:
> > > > Since these are all related changes, doing them at once might make it
> > > > faster. You may use multiple commits (one for each change)
> > >
> > > Doing multiple commits with individual definitions for each path would
> > > be the way to go for me.  All that is mechanical, still that feels
> > > slightly cleaner.
> >
> > Right, that's what v2 has done. If there is a need for v3 then I'll add one
> > dedicated patch for Ashutosh's proposal in the v3 series.
>
> Ashutosh's idea is implemented in v3 that I just shared up-thread (I used
> REPLSLOT_DIR_ARGS though).
>
> Regards,
>
> --
> Bertrand Drouvot
> PostgreSQL Contributors Team
> RDS Open Source Databases
> Amazon Web Services: https://aws.amazon.com



-- 
Best Wishes,
Ashutosh Bapat



Commits

  1. Define PG_TBLSPC_DIR for path pg_tblspc/ in data folder

  2. Define PG_LOGICAL_DIR for path pg_logical/ in data folder

  3. Define PG_REPLSLOT_DIR for path pg_replslot/ in data folder