Re: Memory consumed by child SpecialJoinInfo in partitionwise join planning
Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
To: vignesh C <vignesh21@gmail.com>
Cc: Amit Langote <amitlangote09@gmail.com>,
Richard Guo <guofenglinux@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2024-01-30T05:44:44Z
Lists: pgsql-hackers
Attachments
- 0002-Address-Amit-s-comments-20240130.patch (text/x-patch) patch 0002
- 0001-Reduce-memory-used-by-child-SpecialJoinInfo-20240130.patch (text/x-patch) patch 0001
On Fri, Jan 26, 2024 at 8:42 PM vignesh C <vignesh21@gmail.com> wrote: > > On Wed, 4 Oct 2023 at 04:02, Ashutosh Bapat > <ashutosh.bapat.oss@gmail.com> wrote: > > > > On Fri, Sep 29, 2023 at 8:36 AM Amit Langote <amitlangote09@gmail.com> wrote: > > > IOW, something > > > like the following would have sufficed: .. snip... > > > > Works for me. PFA patchset with these changes. I have still left the > > changes addressing your comments as a separate patch for easier > > review. > > CFBot shows that the patch does not apply anymore as in [1]: > > === Applying patches on top of PostgreSQL commit ID > 55627ba2d334ce98e1f5916354c46472d414bda6 === > === applying patch > ./0001-Report-memory-used-for-planning-a-query-in--20231003.patch > ... > Hunk #1 succeeded at 89 (offset -3 lines). > patching file src/test/regress/expected/explain.out > Hunk #5 FAILED at 285. > Hunk #6 succeeded at 540 (offset 4 lines). > 1 out of 6 hunks FAILED -- saving rejects to file > src/test/regress/expected/explain.out.rej > > Please post an updated version for the same. > > [1] - http://cfbot.cputube.org/patch_46_4500.log Thanks Vignesh. PFA patches rebased on the latest HEAD. The patch addressing Amit's comments is still a separate patch for him to review. -- Best Wishes, Ashutosh Bapat
Commits
-
Code review for 6190d828cd2
- 0f7863afef67 17.0 landed
-
Do not translate dummy SpecialJoinInfos for child joins
- 6190d828cd25 17.0 landed
-
Reduce memory used by partitionwise joins
- 5278d0a2e870 17.0 landed
-
Remove dummy_spinlock
- 55627ba2d334 17.0 cited