Re: PG 18 beta1 release notes misses mention of pg_noreturn
Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
To: Steve Chavez <steve@supabase.io>
Cc: Daniel Gustafsson <daniel@yesql.se>,
PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2025-07-04T14:23:25Z
Lists: pgsql-hackers
On Thu, Jul 3, 2025 at 8:08 PM Steve Chavez <steve@supabase.io> wrote: > > Yes, otherwise I had to grep the commits in `git log` and find what's the correct way to use `pg_noreturn`. > It's not a simple keyword replacement since the order has to change now: > > Old: void my_worker(Datum main_arg) pg_attribute_noreturn(); > > New: pg_noreturn void my_worker(Datum main_arg); > > I've added the link to the commit in the patch, which should be enough to infer the above. > > How can I get this committed? Is the hacker mailing list the right place for release notes correction? > This is the right place to discuss this. Please add your patch to the commitfest App. https://commitfest.postgresql.org/. The landing page has a useful link for first timers. > Best regards, > Steve Chavez > Please do not top-post, reply inline as I have done. -- Best Wishes, Ashutosh Bapat