Horton

Thread

Commits

  1. pg_amcheck: Fix inconsistency in memory freeing

  2. Fix some inconsistencies with memory freeing in pg_createsubscriber

  1. Fix api misuse (src/bin/pg_amcheck/pg_amcheck.c)

    Ranier Vilela <ranier.vf@gmail.com> — 2025-02-18T12:48:07Z

    Hi.

Similar to commit 5b94e27 <http://5b94e2753439b699b78aacbb53e89bf0e814becc>
[1]
The correct function when freeing memory in the frontend,
using the function PQescapeIdentifier, must be
PQfreemem.

Trivial patch attached.

best regards,
Ranier Vilela

[1]
https://www.postgresql.org/message-id/CAEudQAp%3DAW5dJXrGLbC_aZg_9nOo%3D42W7uLDRONFQE-gcgnkgQ%40mail.gmail.com

  2. Re: Fix api misuse (src/bin/pg_amcheck/pg_amcheck.c)

    vignesh C <vignesh21@gmail.com> — 2025-02-26T13:34:25Z

    On Tue, 18 Feb 2025 at 18:18, Ranier Vilela <ranier.vf@gmail.com> wrote:
>
> Hi.
>
> Similar to commit 5b94e27 [1]
> The correct function when freeing memory in the frontend,
> using the function PQescapeIdentifier, must be
> PQfreemem.
>
> Trivial patch attached.

Thanks, this change looks good to me.

Regards,
Vignesh

  3. Re: Fix api misuse (src/bin/pg_amcheck/pg_amcheck.c)

    Michael Paquier <michael@paquier.xyz> — 2025-02-27T05:08:04Z

    On Wed, Feb 26, 2025 at 07:04:25PM +0530, vignesh C wrote:
> On Tue, 18 Feb 2025 at 18:18, Ranier Vilela <ranier.vf@gmail.com> wrote:
>> Similar to commit 5b94e27 [1]
>> The correct function when freeing memory in the frontend,
>> using the function PQescapeIdentifier, must be
>> PQfreemem.
>>
>> Trivial patch attached.
> 
> Thanks, this change looks good to me.

There's no point in leaving that unfixed in pg_amcheck, so done down
to 14 with 48e4ae9a0707.
--
Michael

  4. Re: Fix api misuse (src/bin/pg_amcheck/pg_amcheck.c)

    Ranier Vilela <ranier.vf@gmail.com> — 2025-02-27T11:05:07Z

    Em qui., 27 de fev. de 2025 às 02:08, Michael Paquier <michael@paquier.xyz>
escreveu:

> On Wed, Feb 26, 2025 at 07:04:25PM +0530, vignesh C wrote:
> > On Tue, 18 Feb 2025 at 18:18, Ranier Vilela <ranier.vf@gmail.com> wrote:
> >> Similar to commit 5b94e27 [1]
> >> The correct function when freeing memory in the frontend,
> >> using the function PQescapeIdentifier, must be
> >> PQfreemem.
> >>
> >> Trivial patch attached.
> >
> > Thanks, this change looks good to me.
>
> There's no point in leaving that unfixed in pg_amcheck, so done down
> to 14 with 48e4ae9a0707.
>
Thank you Michael.

best regards,
Ranier Vilela