Horton

Re: Speedup usages of pg_*toa() functions

Ranier Vilela <ranier.vf@gmail.com>

View thread View on postgr.es
From: Ranier Vilela <ranier.vf@gmail.com>
To: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: David Rowley <dgrowleyml@gmail.com>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>, Andres Freund <andres@anarazel.de>
Date: 2020-06-09T21:50:07Z
Lists: pgsql-hackers 
Em ter., 9 de jun. de 2020 às 17:42, Andrew Gierth <
andrew@tao11.riddles.org.uk> escreveu:

> >>>>> "Ranier" == Ranier Vilela <ranier.vf@gmail.com> writes:
>
>  Ranier> So I would change, just the initialization (var uvalue), even
> though it is
>  Ranier> irrelevant.
>
>  Ranier> int
>  Ranier> pg_lltoa(int64 value, char *a)
>  Ranier> {
>  Ranier> int len = 0;
>  Ranier> uint64 uvalue;
>
>  Ranier> if (value < 0)
>  Ranier> {
>  Ranier> uvalue = (uint64) 0 - uvalue;
>
> Use of uninitialized variable.
>
Sorry, my mistake.

uvalue = (uint64) 0 - value;

regards,
Ranier Vilela


>
> --
> Andrew (irc:RhodiumToad)
>

Commits

  1. Have pg_itoa, pg_ltoa and pg_lltoa return the length of the string

  2. Add missing extern keyword for a couple of numutils functions