Re: Avoid unecessary MemSet call (src/backend/utils/cache/relcache.c)

Em seg., 16 de mai. de 2022 às 20:26, David Rowley <dgrowleyml@gmail.com>
escreveu:

> On Sun, 15 May 2022 at 09:47, Ranier Vilela <ranier.vf@gmail.com> wrote:
> > At function load_relcache_init_file, there is an unnecessary function
> call,
> > to initialize pgstat_info pointer to NULL.
> >
> > MemSet(&rel->pgstat_info, 0, sizeof(rel->pgstat_info));
>
> What seems to have happened here is the field was changed to become a
> pointer in 77947c51c.  It's not incorrect to use MemSet() to zero out
> the pointer field.  What it does probably do is confuse the casual
> reader into thinking the field is a struct rather than a pointer to
> one.   It's probably worth making that consistent with the other
> fields so nobody gets confused.
>
> Can you add a CF entry for PG16 for this so we come back to it after we
> branch?
>
Of course.
I will add it.

regards,
Ranier Vilela