Small miscellaneous fixes

Ranier Vilela <ranier.vf@gmail.com>

From: Ranier Vilela <ranier.vf@gmail.com>

To: Pg Hackers <pgsql-hackers@postgresql.org>

Date: 2022-09-30T00:08:02Z

Lists: pgsql-hackers

Attachments

avoid_useless_reassign_lgosegno.patch (application/octet-stream) patch
avoid_useless_retesting_log_min_duration.patch (application/octet-stream) patch
avoid_useless_var_record.patch (application/octet-stream) patch
fix_declaration_volatile_signal_var.patch (application/octet-stream) patch

Hi.

There are assorted fixes to the head branch.

1. Avoid useless reassigning var _logsegno
(src/backend/access/transam/xlog.c)
Commit 7d70809
<https://github.com/postgres/postgres/commit/7d708093b7400327658a30d1aa1d5e284d37622c>
left a little oversight.
XLByteToPrevSeg and XLByteToSeg are macros, and both assign _logsegno.
So, the first assignment is lost and is useless.

2. Avoid retesting log_min_duration (src/backend/commands/analyze.c)
The log_min_duration has already been tested before and the second test
can be safely removed.

3. Avoid useless var declaration record (src/backend/utils/misc/guc.c)
The var record is never really used.

4. Fix declaration volatile signal var (src/bin/pgbench/pgbench.c)
Like how to commit 5ac9e86
<https://github.com/postgres/postgres/commit/5ac9e869191148741539e626b84ba7e77dc71670>,
this is a similar case.

regards,
Ranier Vilela

Commits

Mark two signal flags as sig_atomic_t in pgbench and pg_test_fsync
- 1e314847dd69 16.0 landed
Cleanup useless assignments and checks
- c42cd05c5862 16.0 landed
Mark sigint_interrupt_enabled as sig_atomic_t
- 5ac9e8691911 16.0 cited
Refactor creation of backup_label and backup history files
- 7d708093b740 16.0 cited