Re: Small miscellaneus fixes (Part II)

Ranier Vilela <ranier.vf@gmail.com>

From: Ranier Vilela <ranier.vf@gmail.com>
To: John Naylor <john.naylor@enterprisedb.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>, pgsql-hackers@postgresql.org
Date: 2023-01-16T11:20:46Z
Lists: pgsql-hackers
Em seg., 16 de jan. de 2023 às 03:28, John Naylor <
john.naylor@enterprisedb.com> escreveu:

>
> I wrote:
> > ...but arguably the earlier check is close enough that it's silly to
> assert in the "else" branch, and I'd be okay with just nuking those lines.
> Another thing that caught my attention is the assumption that unsetting a
> bit is so expensive that we have to first check if it's set, so we may as
> well remove "IS_BRACKET(Np->Num)" as well.
>
> The attached is what I mean. I'll commit this this week unless there are
> objections.
>
+1 looks good to me.

regards,
Ranier Vilela

Commits

  1. Remove redundant relkind check

  2. Remove dead code in formatting.c

  3. Fix operator typo in tablecmds.c