Re: Small miscellaneus fixes (Part II)
Ranier Vilela <ranier.vf@gmail.com>
From: Ranier Vilela <ranier.vf@gmail.com>
To: John Naylor <john.naylor@enterprisedb.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>, pgsql-hackers@postgresql.org
Date: 2023-01-17T11:26:11Z
Lists: pgsql-hackers
Em ter., 17 de jan. de 2023 às 04:37, John Naylor < john.naylor@enterprisedb.com> escreveu: > > On Mon, Jan 16, 2023 at 1:28 PM John Naylor <john.naylor@enterprisedb.com> > wrote: > > > > > > I wrote: > > > ...but arguably the earlier check is close enough that it's silly to > assert in the "else" branch, and I'd be okay with just nuking those lines. > Another thing that caught my attention is the assumption that unsetting a > bit is so expensive that we have to first check if it's set, so we may as > well remove "IS_BRACKET(Np->Num)" as well. > > > > The attached is what I mean. I'll commit this this week unless there are > objections. > > I've pushed this and the cosmetic fix in pg_dump. Those were the only > things I saw that had some interest, so I closed the CF entry. > Thanks for the commits. regards, Ranier Vilela
Commits
-
Remove redundant relkind check
- 15eb1228800a 16.0 landed
-
Remove dead code in formatting.c
- e29c5653434e 16.0 landed
-
Fix operator typo in tablecmds.c
- 01be9d498fa4 16.0 landed