Re: Fix out-of-bounds in the function GetCommandTagName

Ranier Vilela <ranier.vf@gmail.com>

From: Ranier Vilela <ranier.vf@gmail.com>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2024-04-15T11:35:55Z
Lists: pgsql-hackers
Em dom., 14 de abr. de 2024 às 23:12, David Rowley <dgrowleyml@gmail.com>
escreveu:

> On Mon, 15 Apr 2024 at 12:12, Ranier Vilela <ranier.vf@gmail.com> wrote:
> >
> > Em dom., 14 de abr. de 2024 às 20:38, David Rowley <dgrowleyml@gmail.com>
> escreveu:
> >> You seem to have forgotten to attach it, but my comments above were
> >> written with the assumption that the patch is what I've attached here.
> >
> > Yes, I actually forgot.
> >
> > +1 for your patch.
>
> I've added a CF entry under your name for this:
> https://commitfest.postgresql.org/48/4927/

Thank you.


>
>
> If it was code new to PG17 I'd be inclined to go ahead with it now,
> but it does not seem to align with making the release mode stable.t
> I'd bet others will feel differently about that.  Delaying seems a
> better default choice at least.
>
I agree. Although I initially thought it was a live bug, that's actually
not the case.
In fact, this is a refactoring.

best regards,
Ranier Vilela

Commits

  1. Remove COMMAND_TAG_NEXTTAG from enum CommandTag.