Re: Redundant Result node

Ranier Vilela <ranier.vf@gmail.com>

From: Ranier Vilela <ranier.vf@gmail.com>

To: Richard Guo <guofenglinux@gmail.com>

Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2024-08-27T11:26:15Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Avoid unnecessary post-sort projection
- 9626068f1333 18.0 landed

Em ter., 27 de ago. de 2024 às 00:43, Richard Guo <guofenglinux@gmail.com>
escreveu:

> On Thu, Aug 22, 2024 at 9:02 PM Ranier Vilela <ranier.vf@gmail.com> wrote:
> > Em qui., 22 de ago. de 2024 às 04:34, Richard Guo <
> guofenglinux@gmail.com> escreveu:
> >> This does not seem right to me, as PathTargets are not canonical, so
> >> we cannot guarantee that two identical PathTargets will have the same
> >> pointer.  Actually, for the query above, the two PathTargets are
> >> identical but have different pointers.
> >
> > Could memcmp solve this?
>
> Hmm, I don't think memcmp works for nodes that contain pointers.
>
The first case which memcmp can fail is if both pointers are null.
But considering the current behavior, the cost vs benefit favors memcmp.

best regards,
Ranier Vilela