Re: Avoid use scoped block variable

Ranier Vilela <ranier.vf@gmail.com>

From: Ranier Vilela <ranier.vf@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2025-12-09T16:24:14Z
Lists: pgsql-hackers
Em ter., 9 de dez. de 2025 às 13:19, Andres Freund <andres@anarazel.de>
escreveu:

> Hi,
>
> On 2025-12-09 13:06:35 -0300, Ranier Vilela wrote:
> > I noticed a possible violation of C rules.
> > Some functions rely on local block variables,
> > but this are a mistake.
> > Once that block exits, the memory of the variable is released.
>
> CStringGetTextDatum() copies its input to a fresh allocation. So there's no
> longer-lived references to the local memory, unless I miss something?
>
Yeah. My bad.
cstring_to_text use palloc.

Sorry for the noise.

best regards,
Ranier Vilela