Re: Fix uninitialized copy_data var (src/backend/commands/subscriptioncmds.c)

Em dom., 27 de jun. de 2021 às 21:18, Peter Smith <smithpb2250@gmail.com>
escreveu:

> On Fri, Jun 25, 2021 at 11:55 PM Ranier Vilela <ranier.vf@gmail.com>
> wrote:
> >
> >
> >
> https://github.com/postgres/postgres/commit/3af10943ce21450e299b3915b9cad47cd90369e9
> > fixes some issues with subscriptioncmds.c, but IMHO still lack this
> issue.
> >
>
> I have not tested this, and gcc gave no warnings about it, but just by
> visual code inspection I do agree with you that this looks like a
> problem, even in the latest code.
>
> IIUC for the case ALTER_SUBSCRIPTION_DROP_PUBLICATION it looks like
> the uninitialized copy_data local stack var would remain uninitialized
> (undefined) still at the time it is passed at
> AlterSubscription_refresh(sub, copy_data);
>
Thanks Peter, for the review.

regards,
Ranier Vilela