Horton

Re: Avoid possible memory leak (src/common/rmtree.c)

Ranier Vilela <ranier.vf@gmail.com>

View thread View on postgr.es
From: Ranier Vilela <ranier.vf@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Daniel Gustafsson <daniel@yesql.se>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2023-07-31T23:10:55Z
Lists: pgsql-hackers 
Em sex, 28 de jul de 2023 11:54 PM, Michael Paquier <michael@paquier.xyz>
escreveu:

> On Tue, Jul 25, 2023 at 04:45:22PM +0200, Daniel Gustafsson wrote:
> > Skimming the tree there doesn't seem to be any callers which aren't
> exiting or
> > ereporting on failure so the real-world impact seems low.  That being
> said,
> > silencing static analyzers could be reason enough to delay allocation.
>
> A different reason would be out-of-core code that uses rmtree() in a
> memory context where the leak would be an issue if facing a failure
> continuously?  Delaying the allocation after the OPENDIR() seems like
> a good practice anyway.
>
Thanks for the commit, Michael.

best regards,
Ranier Vilela

Commits

  1. Avoid memory leak in rmtree() when path cannot be opened