Small miscellaneus fixes (Part II)

Ranier Vilela <ranier.vf@gmail.com>

From: Ranier Vilela <ranier.vf@gmail.com>

To: Pg Hackers <pgsql-hackers@postgresql.org>

Date: 2022-11-25T21:27:04Z

Lists: pgsql-hackers

Attachments

avoid_useless_pointer_increment.patch (application/octet-stream) patch
discard_strtoul_unused_result.patch (application/octet-stream) patch
fix_dead_code_pg_dump.patch (application/octet-stream) patch
fix_dead_code_formatting.patch (application/octet-stream) patch
use_boolean_operator_with_boolean_operands.patch (application/octet-stream) patch

 Hi.

There another assorted fixes to the head branch.

1. Avoid useless pointer increment
(src/backend/utils/activity/pgstat_shmem.c)
The pointer *p, is used in creation dsa memory,
not p + MAXALIGN(pgstat_dsa_init_size()).

2. Discard result unused (src/backend/access/transam/xlogrecovery.c)
Some compilers raise warnings about discarding return from strtoul.

3. Fix dead code (src/bin/pg_dump/pg_dump.c)
tbinfo->relkind == RELKIND_MATVIEW is always true, so "INDEX"
is never hit.
Per Coverity.

4. Fix dead code (src/backend/utils/adt/formatting.c)
Np->sign == '+', is different than "!= '-'" and is different than "!= '+'"
So the else is never hit.
Per Coverity.

5. Use boolean operator with boolean operands
(b/src/backend/commands/tablecmds.c)

regards,
Ranier Vilela

Commits

Remove redundant relkind check
- 15eb1228800a 16.0 landed
Remove dead code in formatting.c
- e29c5653434e 16.0 landed
Fix operator typo in tablecmds.c
- 01be9d498fa4 16.0 landed