Re: Avoid unecessary MemSet call (src/backend/utils/cache/relcache.c)

Ranier Vilela <ranier.vf@gmail.com>

From: Ranier Vilela <ranier.vf@gmail.com>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>, David Rowley <dgrowleyml@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2022-07-16T19:54:56Z
Lists: pgsql-hackers
Em sáb, 16 de jul de 2022 2:58 AM, Peter Eisentraut <
peter.eisentraut@enterprisedb.com> escreveu:

> On 11.07.22 21:06, Ranier Vilela wrote:
> > Em qui., 7 de jul. de 2022 às 14:01, Ranier Vilela <ranier.vf@gmail.com
> > <mailto:ranier.vf@gmail.com>> escreveu:
> >
> >     Attached the v1 of your patch.
> >     I think that all is safe to switch MemSet by {0}.
> >
> > Here the rebased patch v2, against latest head.
>
> I have committed my patch with Álvaro's comments addressed
>
I see.
It's annoing that old compiler (gcc 4.7.2) don't handle this style.


> Your patch appears to add in changes that are either arguably out of
> scope or would need further review (e.g., changing memset() calls,
> changing the scope of some variables, changing places that need to worry
> about padding bits).  Please submit separate patches for those, and we
> can continue the analysis.
>
Sure.

Regards
Ranier Vilela

>

Commits

  1. Replace many MemSet calls with struct initialization

  2. Change some unnecessary MemSet calls

  3. Avoid unnecessary MemSet call