Re: Operands don't affect result (CONSTANT_EXPRESSION_RESULT) (src/backend/utils/adt/jsonfuncs.c)
Ranier Vilela <ranier.vf@gmail.com>
From: Ranier Vilela <ranier.vf@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2021-02-11T21:56:13Z
Lists: pgsql-hackers
Em qui., 11 de fev. de 2021 às 14:51, Tom Lane <tgl@sss.pgh.pa.us> escreveu: > Ranier Vilela <ranier.vf@gmail.com> writes: > > Em qui., 11 de fev. de 2021 às 01:46, Tom Lane <tgl@sss.pgh.pa.us> > escreveu: > >> At the same time, I think this code could be improved; but the way > >> to do that is to use strtoint(), rather than kluging the choice of > >> datatype even further. > > > No matter the function used strtol or strtoint, push_path will remain > > broken with Windows 64bits. > > There is quite a lot of difference between "broken" and "my compiler > generates pointless warnings". Still, I changed it to use strtoint(), > because that's simpler and better style. > Thanks Tom, for fixing this. regards, Ranier Vilela
Commits
-
Simplify jsonfuncs.c code by using strtoint() not strtol().
- 69036aafb9a8 14.0 landed