Re: Use array as object (src/fe_utils/parallel_slot.c)

Ranier Vilela <ranier.vf@gmail.com>

From: Ranier Vilela <ranier.vf@gmail.com>
To: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2022-08-19T18:52:36Z
Lists: pgsql-hackers
Em qui., 11 de ago. de 2022 às 09:52, Ranier Vilela <ranier.vf@gmail.com>
escreveu:

> Hi,
>
> One other case suspicious, which I think deserves a conference.
> At function wait_on_slots (src/fe_utils/parallel_slot.c)
> The variable "slots" are array, but at function call SetCancelConn,
> "slots" are used as an object, which at the very least would be suspicious.
>
The commit
https://github.com/postgres/postgres/commit/f71519e545a34ece0a27c8bb1a2b6e197d323163
Introduced the affected function.
I'm not sure you're having problems, but using arrays as single pointer is
not recommended.

regards,
Ranier Vilela

Commits

  1. Use correct connection for cancellation in frontend's parallel slots

  2. Refactor and generalize the ParallelSlot machinery.