Re: [PATCH] Use optimized single-datum tuplesort in ExecSort

Em qui., 15 de jul. de 2021 às 07:18, Ronan Dunklau <ronan.dunklau@aiven.io>
escreveu:

> Le jeudi 15 juillet 2021, 01:30:26 CEST John Naylor a écrit :
> > On Wed, Jul 14, 2021 at 6:14 AM David Rowley <dgrowleyml@gmail.com>
> wrote:
> > > It would be good to get a 2nd opinion about this idea.  Also, more
> > > benchmark results with v6 and v8 would be good too.
> >
>
> Hello,
>
> Thank you for trying this approach in v8 David !
>
> I've decided to test on more "stable" hardware, an EC-2 medium instance,
> compiling with Debian's gcc 8.3. That's still not ideal but a lot better
> than
> a laptop.
>
> To gather more meaningful results, I ran every pgbench for 30s instead of
> the
> 10 in the initial script provided by David. I ran the full script once for
> HEAD, v6, v8, then a second time for HEAD, v6, v8 to try to eliminate
> noise
> that could happen for 90 consecutive seconds, and took for each of those
> the
> median of the 6 runs.  It's much less noisy than my previous runs but
> still
> not as as stable as I'd like to.
>
> The results are attached in graph form, as well as the raw data if someone
> wants it.
>
> As a conclusion, I don't think it's worth it to introduce a separate
> execprocnode function for that case. It is likely the minor difference
> still
> observed can be explained to noise, as they fluctuate if you compare the
> min,
> max, average or median values from the results.
>
Is there a special reason to not share v7b tests and results?

IMHO he is much more branch friendly.

regards,
Ranier Vilela