Re: [Proposal] Adding Log File Capability to pg_createsubscriber

I have made the changes you suggested and have attached the patch below.

Thanks for your help,
Gyan Sreejith

On Mon, Feb 16, 2026 at 4:14 AM vignesh C <vignesh21@gmail.com> wrote:

> On Mon, 9 Feb 2026 at 07:38, Gyan Sreejith <gyan.sreejith@gmail.com>
> wrote:
> >
> > I was able to make the first two changes that you suggested. However, I
> was not able to get the test to run with one of the existing replica
> servers. I have attached the patch for the first two changes.
>
> For the other comment, you don't need to add a new test case, you have
> to choose one of the existing command_ok tests like:
> command_ok(
> [
> 'pg_createsubscriber',
> '--verbose',
> '--dry-run',
> '--pgdata' => $node_s->data_dir,
> '--publisher-server' => $node_p->connstr($db1),
> '--socketdir' => $node_s->host,
> '--subscriber-port' => $node_s->port,
> '--replication-slot' => 'replslot1',
> ],
> 'run pg_createsubscriber without --databases');
>
> or
>
> command_ok(
> [
> 'pg_createsubscriber',
> '--verbose', '--verbose',
> '--recovery-timeout' => $PostgreSQL::Test::Utils::timeout_default,
> '--pgdata' => $node_s->data_dir,
> '--publisher-server' => $node_p->connstr($db1),
> '--socketdir' => $node_s->host,
> '--subscriber-port' => $node_s->port,
> '--publication' => 'test_pub3',
> '--publication' => 'pub2',
> '--replication-slot' => 'replslot1',
> '--replication-slot' => 'replslot2',
> '--database' => $db1,
> '--database' => $db2,
> '--enable-two-phase',
> '--clean' => 'publications',
> ],
> 'run pg_createsubscriber on node S');
>
> Add --logdir' => $logdir option to this test and include the
> verification you are doing.
>
> Regards,
> Vignesh
>