Horton

Re: gen_guc_tables.pl: Validate required GUC fields before code generation

Chao Li <li.evan.chao@gmail.com>

View thread
From: Chao Li <li.evan.chao@gmail.com>
To: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Cc: Peter Eisentraut <peter@eisentraut.org>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-11-20T05:51:56Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. gen_guc_tables.pl: Validate required GUC fields before code generation

Attachments

On Wed, Nov 19, 2025 at 7:56 PM Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
wrote:

>
> > v3 goes back to v1 plus I add a check for unknown field type per your
> > suggestion, for example:
> > ```
> > error: guc_parameters.data line 2271: unknown GUC type 'intt'
> > ```
>
> We've already validated that the name field exists, so this error
> message should include that, like the other ones do.
>

Make sense. I added field name to this error message in v4, now it looks
like:
```
error: guc_parameters.dat line 2278: 'primary_conninfo' has unknown GUC
type 'string1'
```

Chao Li (Evan)
---------------------
HighGo Software Co., Ltd.
https://www.highgo.com/