Horton

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. pg_visibility: Fix incorrect buffer lock description in comment.

  1. Fix incorrect buffer lock description in pg_visibility comment

    Chao Li <li.evan.chao@gmail.com> — 2025-12-24T02:17:56Z

    Hi Hackers,

While reviewing the patch [1], though I couldn’t raise a comment for it, I
noticed a comment error in the file pg_visibility.c, where a buffer lock is
held in shared mode but the code comment mentioned exclusive mode. I am
filing a small patch to correct the comment.

I only changed "exclusively" to "shared", the format changed was done by
pgindent.

[1]
https://postgr.es/m/CAEze2WgPu-EYYuYQimy=AHQHGa7w8EvLVve5DM5eGMR6zh-7sw@mail.gmail.com

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

  2. Re: Fix incorrect buffer lock description in pg_visibility comment

    Masahiko Sawada <sawada.mshk@gmail.com> — 2025-12-29T18:33:34Z

    Hi,

On Tue, Dec 23, 2025 at 6:18 PM Chao Li <li.evan.chao@gmail.com> wrote:
>
> Hi Hackers,
>
> While reviewing the patch [1], though I couldn’t raise a comment for it, I noticed a comment error in the file pg_visibility.c, where a buffer lock is held in shared mode but the code comment mentioned exclusive mode. I am filing a small patch to correct the comment.
>
> I only changed "exclusively" to "shared", the format changed was done by pgindent.

Yeah, it seems like a typo since the first commit of pg_visiblity,
e472ce9624e0. I think we can backpatch it to all supported versions.

Regards,

-- 
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com