Horton
Menu

Re: Mark function arguments of type "Datum *" as "const Datum *" where possible

Chao Li <li.evan.chao@gmail.com>

View thread
From: Chao Li <li.evan.chao@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Nathan Bossart <nathandbossart@gmail.com>, Michael Paquier <michael@paquier.xyz>, Postgres hackers <pgsql-hackers@lists.postgresql.org>, Peter Eisentraut <peter@eisentraut.org>
Date: 2025-09-28T03:02:32Z
Lists: pgsql-hackers

Attachments

On Fri, Sep 26, 2025 at 11:00 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:

> Yeah.  In particular, probably 99% of such Datum arrays also have an
> associated array of bool isnull flags.  IMO it makes exactly zero
> sense to const-ify the Datums without similar protection for their
> isnull flags.
>
>
Based on Tom's comment, I have made the scope a little broader. If a
function's "Datum *" parameter is changed to const, then if it has a
pairing "bool *isnull" parameter, I make it const as well. Also, if the
function has other pointer parameters that can be const, I change them to
const as well. See v3 attached.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Mark function arguments of type "Datum *" as "const Datum *" where possible