Remove meaningless const qualifier from ginCompressPostingList()

Chao Li <li.evan.chao@gmail.com>

From: Chao Li <li.evan.chao@gmail.com>
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Date: 2025-10-29T03:42:42Z
Lists: pgsql-hackers

Attachments

Hi Hacker,

While working on the other patch that fixed wrong "const" usage [1], I
found the function:
```
GinPostingList *
ginCompressPostingList(const ItemPointer ipd, int nipd, int maxsize,
  int *nwritten)
```
uses "const" unnecessarily. Because it needs to assign an element of "ipd"
to the returned structure "GinPostingList->first" and "first" is a mutable
"ItemPointerData *", so that "ipd" cannot be of const pointer.

With the current usage, "const" only protects "ipd" itself from updating,
which is meaningless. Thus the "const" only adds confusion to code readers,
so I am deleting it.

https://www.postgresql.org/message-id/CAEoWx2m2E0xE8Kvbkv31ULh_E%2B5zph-WA_bEdv3UR9CLhw%2B3vg%40mail.gmail.com

Chao Li (Evan)
---------------------
HighGo Software Co., Ltd.
https://www.highgo.com/

Commits

  1. Fix some confusing uses of const