Re: Proposal: Cascade REPLICA IDENTITY changes to leaf partitions

Chao Li <li.evan.chao@gmail.com>

View thread

From: Chao Li <li.evan.chao@gmail.com>

To: Euler Taveira <euler@eulerto.com>

Cc: Amit Kapila <amit.kapila16@gmail.com>, Postgres hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-12-17T07:56:18Z

Lists: pgsql-hackers

Attachments

v2-0002-Add-INHERIT-NO-INHERIT-options-to-ALTER-TABLE-REP.patch (application/octet-stream) patch v2-0002
v2-0001-Inherit-replica-identity-for-new-and-attached-par.patch (application/octet-stream) patch v2-0001

Hi Amit and Euler,

Thank you both for all your advice. Here comes my first implementation of
INHERIT in the attached v2 patch.

On Wed, Dec 17, 2025 at 8:11 AM Euler Taveira <euler@eulerto.com> wrote:


> I wondering if we use INHERIT as default. The main advantage is usability
> as Chao
> Li already mentioned. Is there any cases that having a different replica
> identity from parent/partitioned table makes sense?
>
>
We can leave this topic open for discussion. In my current implementation,
NO INHERIT is still the default. But if we decide to switch the default, I
can add a new commit that should include only 1 line code change in gram.y
and a tiny doc update.

0001 - when a new partition is created, use the parent's replication
identity
0002 - add INHERIT | NO INHERIT

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/