Horton

Refactor to eliminate cast-away-const in pg_dump object sort comparator

Chao Li <li.evan.chao@gmail.com>

View thread
From: Chao Li <li.evan.chao@gmail.com>
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Noah Misch <noah@leadboat.com>, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2025-12-24T01:58:32Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. ecpg: refactor to eliminate cast-away-const in find_variable().

Attachments

Hi Hacker,

While reviewing patch [1], I raised a comment about cast-away-const in
pg_dump_sort.c. However, the comment was not accepted and the argument was
that the nearby code did the same thing.

I saw Tom recently had a commit [2] that removed some cast-away-const in
ecpg, so I am filing this patch to eliminate all cast-away-const problems
in pg_dump_sort.c.

[1]
https://postgr.es/m/CALDaNm2x3rd7C0_HjUpJFbxpAqXgm=QtoKfkEWDVA8h+JFpa_w@mail.gmail.com
[2]
https://git.postgresql.org/cgit/postgresql.git/commit/?id=4eda42e8bdf5bd3bf69576d54a45c10e7cbc3b35

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/