Horton

Thread

Commits

  1. Fix error message typo.

  1. str_casefold: fix typo in error message

    Chao Li <li.evan.chao@gmail.com> — 2026-01-13T02:09:06Z

    Hi Hacker,

Found this issue while reviewing the other patch. That looks like a
copy-paste error from the initial commit.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

  2. Re: str_casefold: fix typo in error message

    Steven Niu <niushiji@gmail.com> — 2026-01-13T02:16:29Z

    From: Chao Li <li.evan.chao@gmail.com>
Sent: Tuesday, January 13, 2026 10:09
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: str_casefold: fix typo in error message

Hi Hacker,Found this issue while reviewing the other patch. That looks like a copy-paste error from the initial commit.Best regards,--Chao Li (Evan)HighGo Software Co., Ltd.https://www.highgo.com/


Hi, Evan, 

I have a comment. Since it is collid that's being checked and will be used by function pg_newlocale_from_collation(), so I think the change should be:

-						"lower()"),
+						"pg_newlocale_from_collation(()"),

thought? 

Regards,
Steven

  3. Re: str_casefold: fix typo in error message

    Chao Li <li.evan.chao@gmail.com> — 2026-01-13T02:32:41Z

    
> On Jan 13, 2026, at 10:16, Steven Niu <niushiji@gmail.com> wrote:
> 
> From: Chao Li <li.evan.chao@gmail.com>
> Sent: Tuesday, January 13, 2026 10:09
> To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
> Subject: str_casefold: fix typo in error message
> 
> Hi Hacker,Found this issue while reviewing the other patch. That looks like a copy-paste error from the initial commit.Best regards,--Chao Li (Evan)HighGo Software Co., Ltd.https://www.highgo.com/
> 
> 
> Hi, Evan, 
> 
> I have a comment. Since it is collid that's being checked and will be used by function pg_newlocale_from_collation(), so I think the change should be:
> 
> - "lower()"),
> + "pg_newlocale_from_collation(()"),
> 
> thought? 

If you look at other functions in the file, there is a pattern for what it should be. In this patch, I just want to fix the error without breaking the pattern.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

  4. Re: str_casefold: fix typo in error message

    Steven Niu <niushiji@gmail.com> — 2026-01-13T05:33:47Z

    From: Chao Li <li.evan.chao@gmail.com>
Sent: Tuesday, January 13, 2026 10:32
To: Steven Niu <niushiji@gmail.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: str_casefold: fix typo in error message




> On Jan 13, 2026, at 10:16, Steven Niu <niushiji@gmail.com> wrote:
> 
> From: Chao Li <li.evan.chao@gmail.com>
> Sent: Tuesday, January 13, 2026 10:09
> To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
> Subject: str_casefold: fix typo in error message
> 
> Hi Hacker,Found this issue while reviewing the other patch. That looks like a copy-paste error from the initial commit.Best regards,--Chao Li (Evan)HighGo Software Co., Ltd.https://www.highgo.com/
> 
> 
> Hi, Evan, 
> 
> I have a comment. Since it is collid that's being checked and will be used by function pg_newlocale_from_collation(), so I think the change should be:
> 
> - "lower()"),
> + "pg_newlocale_from_collation(()"),
> 
> thought? 

If you look at other functions in the file, there is a pattern for what it should be. In this patch, I just want to fix the error without breaking the pattern.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/



Yeah, I took a look at another function str_initcap() and you are correct. 

Thanks,
Steven