Horton

Re: backend/nodes cleanup: Move loop variables definitions into for statement

Chao Li <li.evan.chao@gmail.com>

View thread View on postgr.es
From: Chao Li <li.evan.chao@gmail.com>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-11-25T03:46:27Z
Lists: pgsql-hackers

Attachments

On Tue, Nov 25, 2025 at 7:38 AM Chao Li <li.evan.chao@gmail.com> wrote:

>
> On Mon, Nov 24, 2025 at 11:00 PM Peter Eisentraut <peter@eisentraut.org>
> wrote:
>
>> On 19.11.25 11:32, Chao Li wrote:
>> > On Wed, Nov 19, 2025 at 5:36 PM Peter Eisentraut <peter@eisentraut.org
>> > <mailto:peter@eisentraut.org>> wrote:
>> >
>> >
>> >
>> >     In a couple of cases, you are changing the type of the loop variable
>> >     from Size to int.  I would not expect such a change in a patch of
>> this
>> >     nature.  If you have a reason to change it, please explain it (but I
>> >     doubt the change is correct).
>> >
>> >
>> > That was a mistake. I fixed it in v3.
>>
>> Still not correct in outDatum().
>>
>>
> Oops! Fixed in v4.
>
>
Rebased to v5.

Chao Li (Evan)
---------------------
HighGo Software Co., Ltd.
https://www.highgo.com/

Commits

  1. backend/nodes cleanup: Move loop variables definitions into for statement

  2. formatting.c cleanup: Move loop variables definitions into for statement