Horton

Re: Refactor to eliminate cast-away-const in pg_dump object sort comparator

Chao Li <li.evan.chao@gmail.com>

View thread
From: Chao Li <li.evan.chao@gmail.com>
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Noah Misch <noah@leadboat.com>, Tom Lane <tgl@sss.pgh.pa.us>, Peter Eisentraut <peter@eisentraut.org>, Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Date: 2025-12-29T09:44:22Z
Lists: pgsql-hackers

Attachments

On Dec 24, 2025, at 09:58, Chao Li <li.evan.chao@gmail.com> wrote:

Hi Hacker,

While reviewing patch [1], I raised a comment about cast-away-const in
pg_dump_sort.c. However, the comment was not accepted and the argument was
that the nearby code did the same thing.

I saw Tom recently had a commit [2] that removed some cast-away-const in
ecpg, so I am filing this patch to eliminate all cast-away-const problems
in pg_dump_sort.c.

[1]
https://postgr.es/m/CALDaNm2x3rd7C0_HjUpJFbxpAqXgm=QtoKfkEWDVA8h+JFpa_w@mail.gmail.com
[2]
https://git.postgresql.org/cgit/postgresql.git/commit/?id=4eda42e8bdf5bd3bf69576d54a45c10e7cbc3b35


I just noticed this patch does the similar thing as [3] just handling a
different file. As Peter had a comment on [3], I addressed the comment as
well in v2.

[3]
https://postgr.es/m/aUQHy/MmWq7c97wK@ip-10-97-1-34.eu-west-3.compute.internal

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/