Re: Postgres, fsync, and OSs (specifically linux)
Thomas Munro <thomas.munro@enterprisedb.com>
From: Thomas Munro <thomas.munro@enterprisedb.com>
To: Craig Ringer <craig@2ndquadrant.com>
Cc: Asim R P <apraveen@pivotal.io>, Pg Hackers <pgsql-hackers@postgresql.org>, Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@anarazel.de>
Date: 2018-11-08T02:41:01Z
Lists: pgsql-hackers
On Fri, Oct 19, 2018 at 6:42 PM Craig Ringer <craig@2ndquadrant.com> wrote: > On Fri, 19 Oct 2018 at 07:27, Thomas Munro <thomas.munro@enterprisedb.com> wrote: >> 2. I am +1 on back-patching Craig's PANIC-on-failure logic. Doing >> nothing is not an option I like. I have some feedback and changes to >> propose though; see attached. > > Thanks very much for the work on reviewing and revising this. My plan is do a round of testing and review of this stuff next week once the dust is settled on the current minor releases (including fixing a few typos I just spotted and some word-smithing). All going well, I will then push the resulting patches to master and all supported stable branches, unless other reviews or objections appear. At some point not too far down the track I hope to be ready to consider committing that other patch that will completely change all of this code in the master branch, but in any case Craig's patch will get almost a full minor release cycle to sit in the stable branches before release. -- Thomas Munro http://www.enterprisedb.com
Commits
-
PANIC on fsync() failure.
- 9ccdd7f66e33 12.0 landed
- f1ff5f51d249 9.4.21 landed
- 312435232217 9.5.16 landed
- b9cce9ddfa17 9.6.12 landed
- afbe03f65470 10.7 landed
- 6534d544cd77 11.2 landed
-
Fix and improve pg_atomic_flag fallback implementation.
- 8c3debbbf618 11.0 cited