Horton

Re: [PATCH] Tab completion for ALTER DATABASE … SET TABLESPACE

Thomas Munro <thomas.munro@enterprisedb.com>

View thread View on postgr.es
From: Thomas Munro <thomas.munro@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Arthur Zakirov <a.zakirov@postgrespro.ru>, Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2018-09-20T21:29:09Z
Lists: pgsql-hackers 
On Fri, Sep 21, 2018 at 9:22 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Arthur Zakirov <a.zakirov@postgrespro.ru> writes:
> > On Thu, Aug 30, 2018 at 05:54:23PM +0100, Dagfinn Ilmari Mannsåker wrote:
> >> And just after hitting send, I noticed I'd typed ALTER TABLE instead of
> >> ALTER DATABASE, including in the commit message :(
> >> Fixed patch attached.
>
> > The patch seems reasonable. It fixes the lack of tab completion for
> > ALTER DATABASE ... SET TABLESPACE ... .
>
> LGTM too, pushed.

+   else if (Matches5("ALTER", "DATABASE", MatchAny, "SET", "TABLESPACE"))

. o O ( hmm, we now have variadic macros )

-- 
Thomas Munro
http://www.enterprisedb.com

Commits

  1. Get rid of explicit argument-count markings in tab-complete.c.

  2. Fix psql's tab completion for ALTER DATABASE ... SET TABLESPACE.