Horton

Re: [HACKERS] Fix warnings and typo in dshash

Thomas Munro <thomas.munro@enterprisedb.com>

View thread View on postgr.es
From: Thomas Munro <thomas.munro@enterprisedb.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2018-02-11T20:23:43Z
Lists: pgsql-hackers

Attachments

On Mon, Sep 4, 2017 at 2:18 PM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> On Sun, Sep 3, 2017 at 2:56 PM, Thomas Munro
> <thomas.munro@enterprisedb.com> wrote:
>> I think it should be (size_t) 1, not UINT64CONST(1).  See attached.
>
> Okay, that makes sense.  Do you think we should also change type
> casting in BUCKETS_PER_PARTITION so that we are consistent?

+1

Here's a patch to fix that.  I was reminded to come back and tidy this
up when I spotted a silly mistake in a nearby comment, also fixed in
this patch.

-- 
Thomas Munro
http://www.enterprisedb.com

Commits

  1. Minor clean-up in dshash.{c,h}.

  2. Suppress compiler warnings in dshash.c.

  3. Fix macro-redefinition warning on MSVC.