Re: infinite loop in parallel hash joins / DSA / get_best_segment

Thomas Munro <thomas.munro@enterprisedb.com>

From: Thomas Munro <thomas.munro@enterprisedb.com>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2018-09-17T23:35:25Z
Lists: pgsql-hackers

Attachments

On Mon, Sep 17, 2018 at 9:12 PM Thomas Munro
<thomas.munro@enterprisedb.com> wrote:
> On Mon, Sep 17, 2018 at 10:42 AM Thomas Munro
> <thomas.munro@enterprisedb.com> wrote:
> > On Mon, Sep 17, 2018 at 10:38 AM Tomas Vondra
> > <tomas.vondra@2ndquadrant.com> wrote:
> > > While performing some benchmarks on REL_11_STABLE (at 444455c2d9), I've
> > > repeatedly hit an apparent infinite loop on TPC-H query 4. I don't know
> > > what exactly are the triggering conditions, but the symptoms are these:
> > >
> > > ...
>
> With the attached draft patch, Tomas's benchmark script runs happily
> for long periods.  A bit more study required with fresh eyes,
> tomorrow.

Here is a tidied up version that I propose to back-patch to 10 & 11.

-- 
Thomas Munro
http://www.enterprisedb.com

Commits

  1. Fix segment_bins corruption in dsa.c.