Horton

Re: pgsql: Add support for coordinating record typmods among parallel worke

Thomas Munro <thomas.munro@enterprisedb.com>

View thread View on postgr.es
From: Thomas Munro <thomas.munro@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, pgsql-committers <pgsql-committers@postgresql.org>
Date: 2017-09-15T04:42:50Z
Lists: pgsql-hackers

Attachments

On Fri, Sep 15, 2017 at 4:34 PM, Thomas Munro
<thomas.munro@enterprisedb.com> wrote:
> Here's a version that just forward declares SharedRecordTypmodRegistry
> in session.h (but keeps the typedef in typcache.h where it is useful
> for shorter function prototypes).  Neither GCC 6 -Wall -std=c89 not
> Clang -Wall -std=c89 complained about this problem.  I found an old
> GCC 4.3 compiler and it complained about the typedef redefinition and
> also the use of an anonymous union, also fixed in the attached.  Sorry
> about that -- clearly I need to test my patches on more compilers in
> future.

Rebased on your fix.  Investigating the runtime failure...

-- 
Thomas Munro
http://www.enterprisedb.com

Commits

  1. Get rid of shared_record_typmod_registry_worker_detach; it doesn't work.

  2. Add support for coordinating record typmods among parallel workers.

  3. Add minimal regression test for blessed record type transfer.