Horton

Re: Loaded footgun open_datasync on Windows

Thomas Munro <thomas.munro@enterprisedb.com>

View thread View on postgr.es
From: Thomas Munro <thomas.munro@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Amit Kapila <amit.kapila16@gmail.com>, Laurenz Albe <laurenz.albe@cybertec.at>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2018-06-06T04:52:46Z
Lists: pgsql-hackers 
On Wed, Jun 6, 2018 at 4:48 PM, Michael Paquier <michael@paquier.xyz> wrote:
> On Wed, Jun 06, 2018 at 09:58:34AM +0530, Amit Kapila wrote:
>> I think we need to explore a bit, if we want to remove that, for example
>> some of the frontend modules (like pg_receivewal, pg_recvlogical) call two
>> argument open which would require change.
>
> Yeah, sure.  I am not saying that this is straight-forward, but it may
> be worth the switch in the long term.  What I am sure about is that the
> proposed patch is simple, but that does not look like a correct
> approach to me as other tools may benefit from it.

Like this other unresolved problem:

https://www.postgresql.org/message-id/flat/16922.1520722108%40sss.pgh.pa.us

-- 
Thomas Munro
http://www.enterprisedb.com

Commits

  1. Allow concurrent-safe open() and fopen() in frontend code for Windows

  2. Fix inclusions of c.h from .h files.

  3. Allow borland compiles.

  4. Corrects issues recently posted by Dann Corbit, allowing libpq/psql to