Horton

Re: Suspicious call of initial_cost_hashjoin()

Thomas Munro <thomas.munro@enterprisedb.com>

View thread View on postgr.es
From: Thomas Munro <thomas.munro@enterprisedb.com>
To: Antonin Houska <ah@cybertec.at>
Cc: David Steele <david@pgmasters.net>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2018-03-02T10:01:33Z
Lists: pgsql-hackers

Attachments

On Fri, Mar 2, 2018 at 9:06 PM, Antonin Houska <ah@cybertec.at> wrote:
> David Steele <david@pgmasters.net> wrote:
>> Does this look right to you?
>
> Yes, this is what I meant. The patch applies cleanly and the code compiles
> well.
>
>> If so, can you sign up as a reviewer and mark it Ready for Committer?
>
> Done.

Thanks.

> Actually I think it'd be nice if the "parallel_hash" argument was mentioned in
> the header comment of initial_cost_hashjoin() function, but not sure this is
> worth returning the patch to the author.

Done.

-- 
Thomas Munro
http://www.enterprisedb.com

Commits

  1. Fix costing of parallel hash joins.

  2. Add parallel-aware hash joins.