Re: pread() and pwrite()

Thomas Munro <thomas.munro@enterprisedb.com>

From: Thomas Munro <thomas.munro@enterprisedb.com>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Jesper Pedersen <jesper.pedersen@redhat.com>, Magnus Hagander <magnus@hagander.net>, Oskari Saarenmaa <os@ohmu.fi>, Pg Hackers <pgsql-hackers@postgresql.org>, Tobias Oberstein <tobias.oberstein@gmail.com>

Date: 2018-10-09T20:56:35Z

Lists: pgsql-hackers

Attachments

0001-Use-pread-pwrite-instead-of-lseek-read-write-v7.patch (application/octet-stream) patch v7-0001

On Tue, Oct 9, 2018 at 5:08 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I wrote:
> > Thomas Munro <thomas.munro@enterprisedb.com> writes:
> >> On Tue, Oct 9, 2018 at 2:55 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >>> Yeah, I've been burnt by that too recently.  It occurs to me we could make
> >>> that at least a little less painful if we formatted the macro with one
> >>> line per function name:
>
> >> +1, was about to suggest the same!
>
> > Sold, I'll go do it.
>
> Learned a few new things about M4 along the way :-( ... but done.
> You'll need to rebase the pread patch again of course.

Thanks, much nicer.  Rebased.

-- 
Thomas Munro
http://www.enterprisedb.com

Commits

Use pg_pread() and pg_pwrite() for data files and WAL.
- c24dcd0cfd94 12.0 landed
Provide pg_pread() and pg_pwrite() for random I/O.
- 3fd2a7932ef0 12.0 landed
Convert some long lists in configure.in to one-line-per-entry style.
- bfa6c5a0c974 12.0 landed