Horton

Re: BUG #14668: BRIN open autosummarize=on , database will crash

Thomas Munro <thomas.munro@enterprisedb.com>

View thread View on postgr.es
From: Thomas Munro <thomas.munro@enterprisedb.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: digoal@126.com, PostgreSQL Bugs <pgsql-bugs@postgresql.org>
Date: 2017-05-31T00:44:01Z
Lists: pgsql-bugs 
On Wed, May 31, 2017 at 10:19 AM, Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:
> Pushed fix.  Actually that's not correct either, because tuples returned
> by brinGetTupleForHeapBlock are not supposed to be freed at all since
> they are shared buffer items.  The correct thing to do there was to
> release the buffer lock ...

Ugh, right, thanks.  I'll blame the myopic analysis on jetlag and lack
of coffee.

-- 
Thomas Munro
http://www.enterprisedb.com

Commits

  1. brin: Don't crash on auto-summarization