Re: A few warnings on Windows
Thomas Munro <thomas.munro@enterprisedb.com>
From: Thomas Munro <thomas.munro@enterprisedb.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Christian Ullrich <chris@chrullrich.net>, Michael Paquier <michael@paquier.xyz>,
Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2018-05-03T23:13:10Z
Lists: pgsql-hackers
On Fri, May 4, 2018 at 2:46 AM, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote: > On 5/3/18 10:18, Tom Lane wrote: >> Christian Ullrich <chris@chrullrich.net> writes: >>>> Thomas Munro <thomas.munro@enterprisedb.com> writes: >>>>> Does anyone know what line 174 of pyconfig.h happens to say? >> >>> typedef _W64 int ssize_t; >>> , in a "not for 64-bit" block. >>> <https://github.com/python/cpython/blob/v3.6.3/PC/pyconfig.h>, 3.6.3 is >>> the installed version on whelk. >> >> Thanks. Not a lot we're going to be able to do about silencing that >> one, I'm afraid. Too bad they haven't wrapped that stanza in >> "#ifndef HAVE_SSIZE_T". > > There is still time to send a patch for Python 3.7. Maybe we could poke this? https://bugs.python.org/issue11717 Apparently ssize_t is not defined on Windows (it's from POSIX, not C) and various projects step on each other's toes defining it. On 64 bit systems we both use __int64. On 32 bit systems, we chose long and they chose int. If we changed our definition to use int too, I assume that would fix the warnings here but might risk creating the opposite problem somewhere else... -- Thomas Munro http://www.enterprisedb.com
Commits
-
Suppress some compiler warnings in plperl on Windows.
- 0996e4be047f 11.0 landed
-
Fix compiler warning on Windows.
- fe4ecd08d81c 11.0 landed
-
Change SIZEOF_BOOL to 1 for Windows.
- 6fe25c1358a2 11.0 landed
-
Fix some assorted compiler warnings on Windows.
- b2328bf62b64 11.0 landed
-
Clean up warnings from -Wimplicit-fallthrough.
- 41c912cad159 11.0 landed